prologic
/
bitcask
3
6
Fork 5
Code Issues 6 Pull Requests 1 Releases 55 Activity
Labels Milestones

Add ErrBadConfig and ErrBadMetadata as errors that consumers can check and use #241

Merged
prologic merged 2 commits from bad_config_metadata_errors into master 1 year ago
Conversation 0 Commits 2 Files Changed 2
prologic commented 1 year ago
Owner

cc @taigrr

This PR will hopefully help to fix some critical isseus in the real world with several or more Yarn.social pods running yarnd where starting back up after a power failure or crash can sometimes result in an empty config.json or empty meta.json or both!

I'm not actually sure how this can arise, and as yet I haven't been able to reproduce it (I can only assume this has to be failures cases outside of our control); but in any case the application and database is recoverable by simply rm config.json and/or rm meta.json.

So this PR makes errors loading the config and metadata first-class errors and exported error types that consumers of the library can use to perform automated recovery without requiring human intervention.

Basiclaly in this case it's no big deal we lost the database config of metadata, we can simply carry on.

cc @taigrr This PR will _hopefully_ help to fix some critical isseus in the real world with several or more [Yarn.social](https://yarn.social) pods running [yarnd](https://git.mills.io/yarnsocial/yarn) where starting back up after a power failure or crash can sometimes result in an empty `config.json` or empty `meta.json` or both! I'm not actually sure how this can arise, and as yet I haven't been able to reproduce it (_I can only assume this has to be failures cases outside of our control_); but in any case the application and database is recoverable by simply `rm config.json` and/or `rm meta.json`. So this PR makes errors loading the config and metadata first-class errors and exported error types that consumers of the library can use to perform automated recovery without requiring human intervention. Basiclaly in this case it's no big deal we lost the database config of metadata, we can simply carry on.
👍 1
prologic added 1 commit 1 year ago
prologic added 1 commit 1 year ago
prologic merged commit 5429693cc8 into master 1 year ago
prologic deleted branch bad_config_metadata_errors 1 year ago
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as 5429693cc8.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something isn't working dependencies
Pull requests that update a dependency file discussion documentation
Documentation sucks duplicate
This issue or pull request already exists enhancement
New feature or request go
Pull requests that update Go code good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right on hold question
Further information is requested stale
Issue or PR that has gone Stale tests wontfix
This will not be worked on
No Label bug dependencies discussion documentation duplicate enhancement go good first issue help wanted invalid on hold question stale tests wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: prologic/bitcask#241
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'bad_config_metadata_errors'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes