Minor cosmetic updates and fix list template due to Command update from commit @0f8b1cbd3b #52

Merged
prologic merged 1 commits from brokenscripts/golinks:master into master 1 week ago
  1. Commit: @0f8b1cbd3b changed Commands to Command in server.go, specifically Line 223. This broke the list.html range template. Small change to fix that.

    Line 223 (server.go): ctx.Set("Command", cmd)

  2. The dockerfile itself, just swapped github.com references to git.mills.io in order for it to actually build on my system.. and it's no longer on Github ;).

  3. Added a simple update to the base.html to add a link directly to list, for the lazy who like to click vice type it in. Small QoL update.
    image

  4. Added a button for each bookmark to have a red X to do a simple remove from the list.html page instead of looking at what you want to remove and then address bar typing it or going back. Small QoL fix.
    image

  5. I've changed the docker start.sh script to actually use environment variables. This will enable the environment syntax (instead of using command) in compose files such as:

    New

    environment:
      - BIND=0.0.0.0:8000
      - BASEURL=http://golinks.mydomain.net
      # BASEURL is extremely convenient when proxying it
    

    Old

    command:
      - bind=0.0.0.0:8000
      - fqdn=http://golinks.mydomain.net
    

    This also prevents from passing something unexpected to golinks.

  6. Lastly! Can you push an updated docker image to Docker Hub? The one on DockerHub is golinks 0.0.5 and the version (before this pull request) is 0.0.7.

1. Commit: @0f8b1cbd3b changed `Commands` to `Command` in `server.go`, specifically Line 223. This broke the `list.html` range template. Small change to fix that. > Line 223 (server.go): `ctx.Set("Command", cmd)` 2. The dockerfile itself, just swapped `github.com` references to `git.mills.io` in order for it to actually build on my system.. and it's no longer on Github ;). 3. Added a simple update to the `base.html` to add a link directly to `list`, for the lazy who like to click vice type it in. Small QoL update. ![image](/attachments/25096cda-2677-4a7c-a022-6d475c6f3cdf) 4. Added a button for each bookmark to have a red **X** to do a simple remove from the `list.html` page instead of looking at what you want to remove and then address bar typing it or going back. Small QoL fix. ![image](/attachments/13379baa-c314-43cf-8858-8628ab1c2f0c) 5. I've changed the docker `start.sh` script to actually use **environment** variables. This will enable the environment syntax (instead of using **command**) in compose files such as: ### New ```yaml environment: - BIND=0.0.0.0:8000 - BASEURL=http://golinks.mydomain.net # BASEURL is extremely convenient when proxying it ``` ### Old ```yaml command: - bind=0.0.0.0:8000 - fqdn=http://golinks.mydomain.net ``` This also prevents from passing something unexpected to golinks. 6. Lastly! Can you push an updated docker image to Docker Hub? The one on DockerHub is golinks 0.0.5 and the version (before this pull request) is 0.0.7.
brokenscripts added 1 commit 1 week ago
brokenscripts changed title from WIP: Minor cosmetic updates and fix list template due to Command update from commit @0f8b1cbd3b to Minor cosmetic updates and fix list template due to Command update from commit @0f8b1cbd3b 1 week ago
Owner

Nice! 👌

Nice! 👌
prologic merged commit 9f7b49eeb9 into master 1 week ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 9f7b49eeb9.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.