prologic
/
tube
3
7
Fork 4
Code Issues 20 Pull Requests Releases 2 Activity
Labels Milestones

Add support for multi-arch binary and docker image releases #20

Merged
prologic merged 6 commits from multi-arch_releases into master 8 months ago
Conversation 15 Commits 6 Files Changed 14
prologic commented 8 months ago
Owner

Fixes #18
Fixes #19

Fixes #18 Fixes #19
prologic added 6 commits 8 months ago
prologic commented 8 months ago
Poster
Owner

Hey @hairyfry and @ways can you have a look at this PR?

Hey @hairyfry and @ways can you have a look at this PR?
👍 1
hairyfry commented 8 months ago

Hey @prologic, thanks so much for taking a crack at it. I pulled the new branch and I can build the the new docker image no problem, especially since it doesn't rely on a seperate image to build.

I ran into a small issue when I tried to mount my own config.json and /data as volumes so I could keep all my old clips and config. It would try to make the tube.db directory and give me a permission denied error. I just unmounted my volumes and let it configure for the first time, then mounted them again and it was happy.

Thanks a ton 👍!

Hey @prologic, thanks so much for taking a crack at it. I pulled the new branch and I can build the the new docker image no problem, especially since it doesn't rely on a seperate image to build. I ran into a small issue when I tried to mount my own `config.json` and `/data` as volumes so I could keep all my old clips and config. It would try to make the tube.db directory and give me a permission denied error. I just unmounted my volumes and let it configure for the first time, then mounted them again and it was happy. Thanks a ton 👍!
prologic commented 8 months ago
Poster
Owner

Hey @prologic, thanks so much for taking a crack at it. I pulled the new branch and I can build the the new docker image no problem, espesially since it doesn't rely on a seperate image to build.

I ran into a small issue when I tried to mount my own config.json and /data as volumes. It would try to make the tube.db directory and give me a permission denied error. I just unmounted my volumes and let it configure for the first time, then mounted them again and it was happy.

Thanks a ton 👍!

So (aside from some congiruation issues you ran into, which we can improve upon) are you happy to have this merged? If so, I'll publish these new images to the Docker Hub and we should be able to (going forward) support Linux/AMD64 and Linux/ARM64 images.

I guess since I'm shoving this into the release process, I'll cut a new release 👌

> Hey @prologic, thanks so much for taking a crack at it. I pulled the new branch and I can build the the new docker image no problem, espesially since it doesn't rely on a seperate image to build. > > I ran into a small issue when I tried to mount my own `config.json` and `/data` as volumes. It would try to make the tube.db directory and give me a permission denied error. I just unmounted my volumes and let it configure for the first time, then mounted them again and it was happy. > > Thanks a ton 👍! So (aside from some congiruation issues you ran into, which we can improve upon) are you happy to have this merged? If so, I'll publish these new images to the Docker Hub and we should be able to (going forward) support Linux/AMD64 and Linux/ARM64 images. I guess since I'm shoving this into the release process, I'll cut a new release 👌
hairyfry commented 8 months ago

Yep, it's looking great. Feel free to merge!

Yep, it's looking great. Feel free to merge!
prologic merged commit 35217febfc into master 8 months ago
prologic commented 8 months ago
Poster
Owner

@hairyfry Done! Cutting a new release now...

When that's done, do you mind updating to the release version and make sure everything is still good on your end? I will do the same on my own instance 👌

@hairyfry Done! Cutting a new release now... When that's done, do you mind updating to the release version and make sure everything is still good on your end? I will do the same on my own instance 👌
prologic commented 8 months ago
Poster
Owner

Tube v1.1.13 is out! 🥳

@hairyfry Please give it a go and LMK how that works out for you 🤗

Tube [v1.1.13](https://git.mills.io/prologic/tube/releases/tag/v1.1.13) is out! 🥳 @hairyfry Please give it a go and LMK how that works out for you 🤗
prologic deleted branch multi-arch_releases 8 months ago
prologic commented 8 months ago
Poster
Owner

All working finr here for me on my tube.mills.io instance.

Had to change my docker-compose.yml a bit

$ git diff tube.yml
diff --git a/public/stacks/tube.yml b/public/stacks/tube.yml
index 34ec5ae..c74b1d1 100644
--- a/public/stacks/tube.yml
+++ b/public/stacks/tube.yml
@@ -3,8 +3,8 @@ version: "3.8"

 services:
   tube:
-    image: r.mills.io/prologic/tube
-    command: -c /config.json
+    image: prologic/tube:1.1.13
+    command: tube -c /config.json
     configs:
       - source: config_json
         target: /config.json

And since I've alwo borrowed the same Docker image setup from some of my other projects, there is a breaking change in that the image is now hardended and no-longer runs as root (uid=0) so I also had to go and chown -R 1000:1000 tube on my data volume.

All working finr here for me on my [tube.mills.io](https://tube.mills.io) instance. Had to change my `docker-compose.yml` a bit ```#!diff $ git diff tube.yml diff --git a/public/stacks/tube.yml b/public/stacks/tube.yml index 34ec5ae..c74b1d1 100644 --- a/public/stacks/tube.yml +++ b/public/stacks/tube.yml @@ -3,8 +3,8 @@ version: "3.8" services: tube: - image: r.mills.io/prologic/tube - command: -c /config.json + image: prologic/tube:1.1.13 + command: tube -c /config.json configs: - source: config_json target: /config.json ``` And since I've alwo borrowed the same Docker image setup from some of my other projects, there is a breaking change in that the image is now hardended and no-longer runs as `root` (`uid=0`) so I also had to go and `chown -R 1000:1000 tube` on my data volume.
hairyfry commented 8 months ago

Yep I also had to chown my data. That's probably what was causing my permision issue.
prologic/tube:1.1.3 pulls and runs perfectly from docker hub and it's what I'm using now. Will you update the latest tag or keep it as numbered releases?

Yep I also had to chown my data. That's probably what was causing my permision issue. `prologic/tube:1.1.3` pulls and runs perfectly from docker hub and it's what I'm using now. Will you update the `latest` tag or keep it as numbered releases?
prologic commented 8 months ago
Poster
Owner

I shall update the latest tag too. I should put that inot CI somehow...

I shall update the latest tag too. I should put that inot CI somehow...
prologic commented 8 months ago
Poster
Owner

Hey btw @hairyfry ... I don't suppose I could interest you in one of my other projects I'm trying to grow? 🤔 Yarn.social

Hey btw @hairyfry ... I don't suppose I could interest you in one of my other projects I'm trying to grow? 🤔 [Yarn.social](https://yarn.social)
prologic commented 8 months ago
Poster
Owner

I shall update the latest tag too. I should put that inot CI somehow...

Done c011bba

> I shall update the latest tag too. I should put that inot CI somehow... Done c011bba
hairyfry commented 8 months ago

Hey btw @hairyfry ... I don't suppose I could interest you in one of my other projects I'm trying to grow? 🤔 Yarn.social

Thanks for the invite but I'm not much of a social media guy 😅. The project does look neat tho

Done c011bba

Perfect! Thanks so much!
This has been the perfect self-hosted replacement for streamable. I use it all the time to share game clips in discord. I'm glad you could squeeze in some time to look at it 😊

> Hey btw @hairyfry ... I don't suppose I could interest you in one of my other projects I'm trying to grow? 🤔 Yarn.social Thanks for the invite but I'm not much of a social media guy 😅. The project does look neat tho > Done c011bba Perfect! Thanks so much! This has been the perfect self-hosted replacement for streamable. I use it all the time to share game clips in discord. I'm glad you could squeeze in some time to look at it 😊
hairyfry commented 8 months ago

Also I think this fixes #15 yeah?

Also I think this fixes #15 yeah?
prologic commented 8 months ago
Poster
Owner

Thanks for the invite but I'm not much of a social media guy 😅. The project does look neat tho

It's not really "social media" 😂 And your comment below makes me think you like to share thing too, but care about where that data goes 😅 (i.e: With Yarn.social it goes nowhere!)

Perfect! Thanks so much!
This has been the perfect self-hosted replacement for streamable. I use it all the time to share game clips in discord. I'm glad you could squeeze in some time to look at it 😊

Oh nice! I'm glad you find it useful I really do! 🤗

> Thanks for the invite but I'm not much of a social media guy 😅. The project does look neat tho It's not really "social media" 😂 And your comment below makes me think you like to share thing too, but care about where that data goes 😅 (i.e: With Yarn.social it goes nowhere!) > Perfect! Thanks so much! > This has been the perfect self-hosted replacement for streamable. I use it all the time to share game clips in discord. I'm glad you could squeeze in some time to look at it 😊 Oh nice! I'm glad you find it useful I really do! 🤗
prologic commented 8 months ago
Poster
Owner

Also I think this fixes #15 yeah?

Oh yes it does!

> Also I think this fixes #15 yeah? Oh yes it does!
The pull request has been merged as 35217febfc.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: prologic/tube#20
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'multi-arch_releases'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes