prologic
/
tube
3
7
Fork 4
Code Issues 20 Pull Requests Releases 2 Activity
Labels Milestones

Remove external FontAwesome dependency #30

Merged
prologic merged 1 commits from ocdtrekkie/tube:master into master 6 months ago
Conversation 0 Commits 1 Files Changed 3
ocdtrekkie commented 6 months ago

This fixes #28.

Since we only use a single FontAwesome, I decided to just use the SVG (which FontAwesome considers the code comment within appropriate attribution). I further decided "screw it, let's inline it", because it avoids unnecessary complexity, and we can always punt it out to another file later if we need to.

This fixes #28. Since we only use a single FontAwesome, I decided to just use the SVG (which FontAwesome considers the code comment within appropriate attribution). I further decided "screw it, let's inline it", because it avoids unnecessary complexity, and we can always punt it out to another file later if we need to.
ocdtrekkie added 1 commit 6 months ago
prologic approved these changes 6 months ago
prologic merged commit d4223a9ef7 into master 6 months ago

Reviewers

prologic approved these changes 6 months ago
The pull request has been merged as d4223a9ef7.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
prologic
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: prologic/tube#30
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ocdtrekkie/tube:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes