feat: Make upload path selectable #39

Merged
prologic merged 3 commits from gumbo2000/tube:add-upload-target-library-path-selector into master 4 months ago
Collaborator

This works for me, but for a more public site, I think I'll also add a boolean attribute named "upload_allowed" and "writable" to Config.Library..

Something to allow you to configure which directories can receive new uploads, and which directories we consider writable for other purposes (like editing meta data in yml, creating new thumbnails, ...)

This works for me, but for a more public site, I think I'll also add a boolean attribute named "upload_allowed" and "writable" to Config.Library.. Something to allow you to configure which directories can receive new uploads, and which directories we consider writable for other purposes (like editing meta data in yml, creating new thumbnails, ...)
gumbo2000 added 1 commit 4 months ago
continuous-integration/drone/pr Build is passing Details
b8d1ccae87
feat: Make upload path selectable
prologic reviewed 4 months ago
keys := make([]string, 0, len(a.Library.Paths))
for k := range a.Library.Paths {
keys = append(keys, k)
if _, exists := a.Library.Paths[targetLibraryPath]; exists {
Owner

Maybe let's invert this check and return early?

Maybe let's invert this check and return early?
gumbo2000 marked this conversation as resolved
prologic approved these changes 4 months ago
prologic left a comment
Owner

LGTM 👌

LGTM 👌
gumbo2000 added 1 commit 4 months ago
gumbo2000 added 1 commit 4 months ago
continuous-integration/drone/pr Build is passing Details
ca939eb7f5
fix: Add missing declaration of targetLibraryPath
Poster
Collaborator

I think that'll be all from me for today. I'll be on holidays for the next two weeks.
Not sure if I will get around to do any coding.
see ya!

I think that'll be all from me for today. I'll be on holidays for the next two weeks. Not sure if I will get around to do any coding. see ya!
gumbo2000 requested review from prologic 4 months ago
prologic merged commit 0a793f7d3f into master 4 months ago
prologic deleted branch add-upload-target-library-path-selector 4 months ago
prologic referenced this issue from a commit 4 months ago

Reviewers

prologic was requested for review 4 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 0a793f7d3f.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: prologic/tube#39
Loading…
There is no content yet.