yarnsocial
/
app
21
2
Fork 3
Code Issues 44 Pull Requests Releases 5 Activity
Labels Milestones

Fixes issues 175,172,54 #174

Merged
prologic merged 5 commits from pratikbaid3/app:feat/172/link-opening-issue into master 4 days ago
Conversation 8 Commits 5 Files Changed 4
pratikbaid3 commented 2 weeks ago
Owner

Closes #172
Closes #175
Closes #54

Closes #172 Closes #175 Closes #54
pratikbaid3 added 2 commits 2 weeks ago
pratikbaid3 added 1 commit 2 weeks ago
pratikbaid3 added 1 commit 2 weeks ago
pratikbaid3 added 1 commit 2 weeks ago
pratikbaid3 changed title from feat/172/link-opening-issue to Fixes issues 175,172,54 2 weeks ago
marado commented 1 week ago

Since you're partially fixing the identation of the AndroidManifest, you might want to consider adding this commit to this PR:
ca9b189b82

Since you're partially fixing the identation of the AndroidManifest, you might want to consider adding this commit to this PR: https://git.mills.io/marado/app/commit/ca9b189b824cbffcd45de9a6ff0f552e90520f1b
marado commented 1 week ago

Tested:
👍 links work
👍 HTML within feed items renders properly
👎 there is still unrendered HTML in profile descriptions (see screenshot)

Tested: 👍 links work 👍 HTML within feed items renders properly 👎 there is still unrendered HTML in profile descriptions (see screenshot)
rlaf.jpg
76 KiB
marado commented 1 week ago

Also, we might be de-htmlizing a bit too much: see attachment with the comparison between web and mobile app, where, in the app, a link isn't click able.

Also, we might be de-htmlizing a bit too much: see attachment with the comparison between web and mobile app, where, in the app, a link isn't click able.
Screenshot_20230315_215354_Chrome.jpg
318 KiB
marado commented 1 week ago

https://pub.dev/documentation/url_launcher/latest/url_launcher/launchUrl.html

can we use LaunchMode.externalApplication, as documented in the above link?

The current mode doesn't allow for a full browsing experience (at least on android), and the user ends up unable from doing things like copying a link, opening it into a new tab, sharing to another app, etc..

https://pub.dev/documentation/url_launcher/latest/url_launcher/launchUrl.html can we use LaunchMode.externalApplication, as documented in the above link? The current mode doesn't allow for a full browsing experience (at least on android), and the user ends up unable from doing things like copying a link, opening it into a new tab, sharing to another app, etc..
prologic commented 6 days ago
Owner

@marado Shall we do this in another PR?

@marado Shall we do this in another PR?
prologic commented 4 days ago
Owner

Going ot merge this for now and we'll fix other things in new PRs

Going ot merge this for now and we'll fix other things in new PRs
prologic merged commit 39c864d8b5 into master 4 days ago
prologic referenced this issue from a commit 4 days ago
Fixes issues 175,172,54 (#174)
prologic deleted branch feat/172/link-opening-issue 4 days ago
marado commented 3 days ago

Will open issues for the my previous comments.

Will open issues for the my previous comments.
❤️ 1
prologic commented 3 days ago
Owner

Thank you! 🙏

Thank you! 🙏
The pull request has been merged as 39c864d8b5.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested wontfix
This will not be worked on
No Label bug documentation duplicate enhancement good first issue help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: yarnsocial/app#174
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pratikbaid3/app:feat/172/link-opening-issue'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes