When we create a tweet through a /post endopint, we should get back the tweet created.
Co-authored-by: Felipe Dutra Tine e Silva <felipe.dutratineesilva@mindgeek.com>
Reviewed-on: #1006
Reviewed-by: James Mills <james@mills.io>
Co-authored-by: tkanos <tkanos@noreply@mills.io>
Co-committed-by: tkanos <tkanos@noreply@mills.io>
Fixes#976@mckinley I'm going to run this on [yarn.mills.io](https://yarn.mills.io) -- a private pod of mine on this branch.
If you wouldn't mind testing/confirming the fix for me? Thanks! 🙏
Co-authored-by: James Mills <prologic@shortcircuit.net.au>
Reviewed-on: #1001
Replacing pico.css with simple.css along with some small UI changes
Co-authored-by: sorenpeter <sp@darch.dk>
Co-authored-by: James Mills <prologic@shortcircuit.net.au>
Reviewed-on: #990
Reviewed-by: James Mills <james@mills.io>
Co-authored-by: sorenpeter <sorenpeter@noreply@mills.io>
Co-committed-by: sorenpeter <sorenpeter@noreply@mills.io>
There is one severe bug in the user registration that must be considered
a security vulnerability. Even though registration was disabled in the
configuration, simply POSTing the registration form caused the feature
flag to be bypassed and thus the new user account to be successfully
created.
Also, we now send proper HTTP error status codes in the registration and
login handlers.
The go.mod and go.sum files were updated with `go mod tidy`.
This is yet another bandaid on the session code. There are some
endpoints that never make use of sessions. So just don't create any.
Ideally, we would do it the other way around and register the session
mangement handler only for the routes, that (potentially) require a
session. But again, more refactoring is required to do it properly.
This code is heavily inspired by the nosurf module.
The previous commit changed the session management behavior. Prior to
that, when no cookie was sent along to obtain a session ID from, a new
session was created and a new cookie containing the session ID was
produced. The last commit only sends a session cookie when there is a
true need for it. So basically only for logged in users and anonymous
users who visit the support contact page.
All other anonymous requests create an empty session and store it only
on the server. This causes a lot of empty, useless sessions laying
around.
So in order to not waste memory on garbage and also maintain a healthy
data hygiene, only store new sessions if they have some data assigned.
Even better would be to only create a session if truly needed. But that
is a bigger change, so use a bandaid for now.
This partially resolves #771
and is the first step towards getting rid of unnecessary session
cookies.
The CSRF cookie is still sent all the time! It will be fixed later.
This commit tries to be as less invasive as possible. Ideally, the
session management would be refactored completely to simplify it and get
rid of these weird code paths with callbacks and stuff.
For clearing the cookie an expiration timestamp in the past is chosen.
This will make sure that cookie removal works even if clocks are not
synchronized. It should be much more robust than expiring the cookie at
the current point in time.
During development, when starting yarnd with `make dev` it's very
annoying that it attempts to send e-mails to GMail which of course will
fail with the default invalid username and password. So just skip
sending e-mails if the SMTP config is clearly invalid.
Make SMTP hostname and port also invalid in the default config to be
consistent with the other SMTP settings username, password and from.
I don't see a reason why GMail should be the default configuration.
Watch out, this change is backwards-incompatible in regards to default
hostname and port! In case GMail users haven't set the SMTP hostname and
port settings in their configs and relied on the default ones, they will
now have a problem. Sending e-mails will be disabled. However, just
explicitly setting both SMTP hostname and port will bring them back to
business.
The test file had a plural `_tests` suffix, so it was actually not
detected as a test file. Renaming it to a singular `_test` suffix
revealed that the test actually failed.
It's not entirely obvious to me whether the test or the implementation
was wrong. But just a newline at the end should not hurt. In fact, it's
always good to end text files with a final newline. There are old tools
out there which ignore the last line if it does not end with a newline.
So I decided to fix the test and leave the implementation alone. To
cement that final newline behavior I added a test for a single line.
Fix modal content closing errors
* Changed to selector array for any future modal closure
Fix bookmarklet with existing text and clearing with posting
* Fixes#950
Multiple JS optimisations and general cleanliness
Co-authored-by: Phil S <phil@git.ullarah.com>
Co-authored-by: Phil S <ullarah@noreply@mills.io>
Reviewed-on: #955
Co-authored-by: Phil S. <ullarah@noreply@mills.io>
Co-committed-by: Phil S. <ullarah@noreply@mills.io>
Fixes#940
This PR adds an additional setting for users to set their start page upon login.
Origin will use the original way of redirection which is to use the referer value.
Co-authored-by: Phil S <phil@git.ullarah.com>
Co-authored-by: Phil S <ullarah@noreply@mills.io>
Reviewed-on: #956
Co-authored-by: Phil S. <ullarah@noreply@mills.io>
Co-committed-by: Phil S. <ullarah@noreply@mills.io>
As per title.
This adds a 'healthy' status to the docker container status.
cc @prologic
Co-authored-by: Phil S <ullarah@noreply@mills.io>
Reviewed-on: #958
Co-authored-by: Phil S. <ullarah@noreply@mills.io>
Co-committed-by: Phil S. <ullarah@noreply@mills.io>
Remove unrequired @media sections
Merge similar CSS elements
Creation of header element for top navigation bar
Fix search bar text compress bug
Co-authored-by: Phil S <phil@git.ullarah.com>
Reviewed-on: #949
Co-authored-by: Phil S. <ullarah@noreply@mills.io>
Co-committed-by: Phil S. <ullarah@noreply@mills.io>
Fixes#946
Co-authored-by: Phil S <ullarah@noreply@mills.io>
Reviewed-on: #948
Co-authored-by: Phil S. <ullarah@noreply@mills.io>
Co-committed-by: Phil S. <ullarah@noreply@mills.io>
hi~ mills and other friends
this merge is all about Chinese translation improvement
1. adjust some inappropriate translation
2. complete almost all untranslated part except pod management
3. create a chinese transaltion guideline, see README at https://git.mills.io/jim/yarn-trans-gl or just read it here.
the things i want you to know is that my friends and i came a really cool Chinese name for yarn and yarn.social but I think yarn.social is a **trademark** and **a symbol of you and many others hardwork**, so i decide to **keep yarn.social not translated** but add the cool Chines name in parentheses after it, hope you'll happy about that!
the current guideline is below:
# 目的 Purpose
Yarn.social网站中文翻译准则，目的是确保网站翻译的一致性
Yarn.social website Chinese translation guidline, the purpose is to keep consistency for the whole translation
# 翻译原则 tranlation principles
1. 信雅达，以信为先
forgive me, it would very offensive to tranlate these principles with my low level, because these principles are set out by one of the greatest chinese translator who's name is Yan Fu(严复)
2. 以推特的用语为主，兼顾微博的用语
mainly used the twitter(which is blocked in mainland china) terms and also considering the weibo(which is more popular in china) terms
# 不翻译的词 Words NOT Translated
1. feed
2. token
3. URL
4. yarn.social 但会在末尾括号加上中文名
# 常用名词对照表 Glossary
| English | 汉语
| --- | ---
| yarn | 言，织言
| yarn.social | yarn.social(织言社交)
| pod | 节点
| instance | 节点
| link | 链接
| follower | 关注者
| following | 正在关注
| timeline | 动态
| twt | 推文
| post | 帖子
| profile | 用户资料
| magic-link-auth | 鉴权魔法链接
| mute | 屏蔽
* yarn.social是一个商标，要保持这个英文商标，把翻译放到括号里
yarn.social is a trademark, remember that, so keep this English trademark, and put in parentheses.
# 改进 Improvements
欢迎进行讨论提供改进意见
improvements are welcomed
Co-authored-by: Jim Green <jimgreen2013@qq.com>
Co-authored-by: jim <chsing@pm.me>
Reviewed-on: #938
Reviewed-by: James Mills <james@mills.io>
Co-authored-by: jim <jim@noreply@mills.io>
Co-committed-by: jim <jim@noreply@mills.io>
Holy mackeral I think this small little change has fixed#923!
I found this by complete accident whilst working on the Trix editor.
The 'in-reply-to' shows the first item in the list however, in my opinion, this will be sufficient in displaying the context.
cc @prologic
Co-authored-by: Phil S <ullarah@noreply@mills.io>
Co-authored-by: Phil S <phil@git.ullarah.com>
Reviewed-on: #936
Reviewed-by: James Mills <james@mills.io>
Co-authored-by: Phil S. <ullarah@noreply@mills.io>
Co-committed-by: Phil S. <ullarah@noreply@mills.io>
this changeset addresses the need to rapidly deploy a yarn pod using common patterns via vps/vm, traefik, docker swarm, and cloudflare.
more guides and example will be added as time allows, but for now this has worked for @Screem@prologic and others
Reviewed-on: #933
Reviewed-by: James Mills <james@mills.io>
Co-authored-by: m u t e f a l l <mutefall@noreply@mills.io>
Co-committed-by: m u t e f a l l <mutefall@noreply@mills.io>
Additional fix for minor issue with burger menu
Co-authored-by: Phil S <ullarah@noreply@mills.io>
Reviewed-on: #927
Reviewed-by: James Mills <james@mills.io>
Co-authored-by: Phil S. <ullarah@noreply@mills.io>
Co-committed-by: Phil S. <ullarah@noreply@mills.io>
Forgot to make a PR of this branch!
cc @prologic
Co-authored-by: Phil S <phil@git.ullarah.com>
Reviewed-on: #926
Co-authored-by: Phil S. <ullarah@noreply@mills.io>
Co-committed-by: Phil S. <ullarah@noreply@mills.io>
Add domain to lookup structure
Add utility for mention lookup to return domain
Fix mention list button on format toolbar
Adjust mention list to inline under post box
Resolves#838
Co-authored-by: Phil S <phil@git.ullarah.com>
Reviewed-on: #920
Co-authored-by: Phil S. <ullarah@noreply@mills.io>
Co-committed-by: Phil S. <ullarah@noreply@mills.io>
m u t e f a l l