Add support for Filter and Lists #1059

Merged
prologic merged 9 commits from filter_and_lists into main 2 weeks ago
Owner
There is no content yet.
prologic added 1 commit 4 weeks ago
5f6209f5e8
Add support for Filter and Lists
prologic requested review from xuu 4 weeks ago
prologic requested review from sorenpeter 4 weeks ago
prologic requested review from tkanos 4 weeks ago
prologic requested review from eaplmx 4 weeks ago
Poster
Owner

Even though this is still Work-in-Progress (I haven't built the Lists feature yet... I'm putting this up for early review and deploying to my Pod at twtxt.net) -- Assuming nothing breaks I will merge this PR and continue devleopment as hopefully 🤞 the new feature is entirely under a Feature Flag

Even though this is still Work-in-Progress (_I haven't built the Lists feature yet... I'm putting this up for early review and deploying to my Pod at twtxt.net_) -- Assuming nothing breaks I will merge this PR and continue devleopment as _hopefully_ 🤞 the new feature is entirely under a [Feature Flag](https://git.mills.io/yarnsocial/yarn/wiki/Feature-Flagging)
prologic changed title from Add support for Filter and Lists to WIP: Add support for Filter and Lists 4 weeks ago
Owner

This is an excellent change. However, the filters don't seem to work until you sign in to an account.

This is an excellent change. However, the filters don't seem to work until you sign in to an account.
Owner

Also, the filter buttons are present on /search but enabling one replaces the search query as the first option in the query string.

Example:

The filter buttons on https://twtxt.net/search?tag=xi7nivq lead to https://twtxt.net/search?f=mentionsme and so on.

Filters don't seem to work for /search anyway.

https://twtxt.net/search?f=noreplies&tag=xi7nivq
https://twtxt.net/search?tag=xi7nivq&f=noreplies

Also, the filter buttons are present on /search but enabling one replaces the search query as the first option in the query string. Example: The filter buttons on `https://twtxt.net/search?tag=xi7nivq` lead to `https://twtxt.net/search?f=mentionsme` and so on. Filters don't seem to work for /search anyway. https://twtxt.net/search?f=noreplies&tag=xi7nivq https://twtxt.net/search?tag=xi7nivq&f=noreplies
Poster
Owner

Thanks for testing @mckinley 🙇‍♂️ Yeah I don't think these filters (as they're cache-level) make sense for Seach. I might hide them on that view? 🤔

As for your other comment, I'l look into why they don't work when you're not logged in, at least some of them should that don't require to know who you are (e.g: Mentions).

Thanks for testing @mckinley 🙇‍♂️ Yeah I don't think these filters (as they're cache-level) make sense for Seach. I might hide them on that view? 🤔 As for your other comment, I'l look into why they don't work when you're not logged in, at least _some_ of them should that don't require to know who you are (e.g: Mentions).
prologic force-pushed filter_and_lists from 5f6209f5e8 to 5054dc9002 3 weeks ago
prologic force-pushed filter_and_lists from 5054dc9002 to 1ddad1dc54 3 weeks ago

Hey, I'm testing on twtxt as I noticed the banner but I'm confused about how it works.

It doesn't filter my mentions properly, and it seems to give an error when filtering on external feeds in a profile page, I thought I could filter even on profiles since it was just under the post editor.

Is there a description of the feature I might have missed?

Hey, I'm testing on twtxt as I noticed the banner but I'm confused about how it works. It doesn't filter my mentions properly, and it seems to give an error when filtering on external feeds in a profile page, I thought I could filter even on profiles since it was just under the post editor. Is there a description of the feature I might have missed?
Poster
Owner

It doesn't filter my mentions properly, and it seems to give an error when filtering on external feeds in a profile page, I thought I could filter even on profiles since it was just under the post editor.

This is a bug. @mckinley found a simialr issue for Search too. I think we should nto show the Cache filters in this case...

Is there a description of the feature I might have missed?

Not really, as I'm basically evolving the features as we I go along, which is why they're under a Feature Flag 😅

> It doesn't filter my mentions properly, and it seems to give an error when filtering on external feeds in a profile page, I thought I could filter even on profiles since it was just under the post editor. This is a bug. @mckinley found a simialr issue for Search too. I _think_ we should nto show the Cache filters in this case... > Is there a description of the feature I might have missed? Not really, as I'm basically evolving the features as we I go along, which is why they're under a Feature Flag 😅
prologic added 1 commit 3 weeks ago
da7a0bbaeb
Fix filter nav to only show on timeline view
Poster
Owner

@mckinley / @justamoment I've since fixed both issues you've both found and pushed ot my pod 👌

@mckinley / @justamoment I've since fixed both issues you've both found and pushed ot my pod 👌
prologic added 1 commit 3 weeks ago
5be1ff7e4b
Add octobloc.xyz to known pods

@prologic Sorry to say but it seems that I can't see all my own mentions like this one here

@prologic Sorry to say but it seems that I can't see all my own mentions like [this one here](https://twtxt.net/conv/cpijxqa)
Poster
Owner

@prologic Sorry to say but it seems that I can't see all my own mentions like this one here

Hmmm I just synced my feeed locally yarnc sync twtxt.txt so I could "grep" my feed to have a looksie:

$ sift 'cc.*justa' twtxt.txt
...
3475:2022-10-20T01:03:26Z	(#dp3gv6q)  cc @<justamoment https://twtxt.net/user/justamoment/twtxt.txt>
4214:2022-11-05T22:52:24Z	(#cpijxqa) cc @<justamoment https://twtxt.net/user/justamoment/twtxt.txt>

I don't see anything "wrong" there in my @-mention for you, so very curious how the "Mentions me" filter isn't working for you? Its actually the same code that was there before that drove the "Mentions" view at /mentions (the old behaviour) -- Did that work for you too or not? 🤔

I'll have a look at the code...

> @prologic Sorry to say but it seems that I can't see all my own mentions like [this one here](https://twtxt.net/conv/cpijxqa) Hmmm I just synced my feeed locally `yarnc sync twtxt.txt` so I could "grep" my feed to have a looksie: ```console $ sift 'cc.*justa' twtxt.txt ... 3475:2022-10-20T01:03:26Z (#dp3gv6q) cc @<justamoment https://twtxt.net/user/justamoment/twtxt.txt> 4214:2022-11-05T22:52:24Z (#cpijxqa) cc @<justamoment https://twtxt.net/user/justamoment/twtxt.txt> ``` I don't see anything "wrong" there in my @-mention for you, so very curious how the "Mentions me" filter isn't working for you? Its actually the same code that was there before that drove the "Mentions" view at /mentions (the old behaviour) -- Did that work for you too or not? 🤔 I'll have a look at the code...

@prologic I just noticed that the mentions disappear when they're not the last post of a conversation, I then checked in the settings and it seems to actually work again if I select to view my timeline as "List" I usually keep it as "Flat" so it includes only the last post, that's where it breaks, or rather where it get filtered out.

Mentions should probably have a different filtering to ensure it works in every cases.

@prologic I just noticed that the mentions disappear when they're not the last post of a conversation, I then checked in the settings and it seems to actually work again if I select to view my timeline as "List" I usually keep it as "Flat" so it includes only the last post, that's where it breaks, or rather where it get filtered out. Mentions should probably have a different filtering to ensure it works in every cases.
prologic added 1 commit 3 weeks ago
prologic added 1 commit 3 weeks ago
Owner

@prologic The additive filters are a great idea and I appreciate your commitment to making things work without JavaScript.

Does the "No Replies" option mean "only posts without replies" or "exclude replies from the feed"?

Also:

@​mckinley / @​justamoment I've since fixed both issues you've both found and pushed ot my pod 👌

I'm not sure exactly what you're referring to here, but filters still don't work without being signed in.

@prologic The additive filters are a great idea and I appreciate your commitment to making things work without JavaScript. Does the "No Replies" option mean "only posts without replies" or "exclude replies from the feed"? Also: > @​mckinley / @​justamoment I've since fixed both issues you've both found and pushed ot my pod 👌 I'm not sure exactly what you're referring to here, but filters still don't work without being signed in.
Poster
Owner

@justamoment Hmmm I see... Might be worth another separate issue to track that? Unless you're saying its a specific bug wtih the changes in this PR? 🤔

@justamoment Hmmm I see... Might be worth another separate issue to track that? Unless you're saying its a specific bug wtih the changes in this PR? 🤔
Poster
Owner

@mckinley

Does the "No Replies" option mean "only posts without replies" or "exclude replies from the feed"?

The former. Basically Twts that hasn't been replied to yet (have 0 Twts in their Conversation chain) -- Feel free to suggest better language 😅

@mckinley > Does the "No Replies" option mean "only posts without replies" or "exclude replies from the feed"? The former. Basically Twts that hasn't been replied to yet (have 0 Twts in their Conversation chain) -- Feel free to suggest better language 😅
Poster
Owner

@mckinley

I'm not sure exactly what you're referring to here, but filters still don't work without being signed in.

Hmmm you are right... I wonder what's going on there...

@mckinley > I'm not sure exactly what you're referring to here, but filters still don't work without being signed in. Hmmm you are right... I wonder what's going on there...
prologic added 1 commit 3 weeks ago
44cb50fb22
Make filters work anonymously
Poster
Owner

Fixed

Fixed

@justamoment Hmmm I see... Might be worth another separate issue to track that? Unless you're saying its a specific bug wtih the changes in this PR? 🤔

@prologic I don't know myself, is it managed differently?

I thought it was the same, maybe changing from first filtering then hiding the replies, but I'm not sure how you handled the timeline visibility.

> @justamoment Hmmm I see... Might be worth another separate issue to track that? Unless you're saying its a specific bug wtih the changes in this PR? 🤔 @prologic I don't know myself, is it managed differently? I thought it was the same, maybe changing from first filtering then hiding the replies, but I'm not sure how you handled the timeline visibility.

@mckinley

Does the "No Replies" option mean "only posts without replies" or "exclude replies from the feed"?

The former. Basically Twts that hasn't been replied to yet (have 0 Twts in their Conversation chain) -- Feel free to suggest better language 😅

@prologic @mckinley maybe a "No Conversation" or "Single Posts"?

> @mckinley > > > Does the "No Replies" option mean "only posts without replies" or "exclude replies from the feed"? > > The former. Basically Twts that hasn't been replied to yet (have 0 Twts in their Conversation chain) -- Feel free to suggest better language 😅 @prologic @mckinley maybe a "No Conversation" or "Single Posts"?
Poster
Owner

@justamoment I filed a separate issue in #1062 for this, and yeah its probably an easys fix, though it might be worthwhile refactoring that section of code a. bit 👌

@justamoment I filed a separate issue in #1062 for this, and yeah its probably an easys fix, though it _might_ be worthwhile refactoring that section of code a. bit 👌

@justamoment I filed a separate issue in #1062 for this, and yeah its probably an easys fix, though it might be worthwhile refactoring that section of code a. bit 👌

@prologic yeah, just saw it. 🤟

> @justamoment I filed a separate issue in #1062 for this, and yeah its probably an easys fix, though it _might_ be worthwhile refactoring that section of code a. bit 👌 @prologic yeah, just saw it. 🤟

@prologic Another issue on the current pod (twtxt.net), the filters seems to reset if you change page.

@prologic Another issue on the current pod (twtxt.net), the filters seems to reset if you change page.
prologic added 1 commit 3 weeks ago
prologic added 1 commit 3 weeks ago
prologic force-pushed filter_and_lists from fd3e683588 to 0d75180017 3 weeks ago
Poster
Owner

@prologic Another issue on the current pod (twtxt.net), the filters seems to reset if you change page.

Thanks! I hadn't noticed! I'll try to fix that 👌

> @prologic Another issue on the current pod (twtxt.net), the filters seems to reset if you change page. Thanks! I hadn't noticed! I'll try to fix that 👌
prologic force-pushed filter_and_lists from 0d75180017 to 9ca47849a9 3 weeks ago
prologic added 1 commit 3 weeks ago
prologic force-pushed filter_and_lists from 705ffa5d9e to 645f51b745 2 weeks ago
prologic force-pushed filter_and_lists from 645f51b745 to 38f05adbdb 2 weeks ago
prologic force-pushed filter_and_lists from 38f05adbdb to 7ccb64d063 2 weeks ago
prologic changed title from WIP: Add support for Filter and Lists to Add support for Filter and Lists 2 weeks ago
Poster
Owner

Going to merge this for several reasons:

  • I thnk we've already found it useful (at least on my pod where its enabled)
  • I believe in incremental small changes. This is behind a feature flag so it's ok 👌
  • Nothing bad broke 🤣
Going to merge this for several reasons: - I _thnk_ we've already found it useful (_at least on my pod where its enabled_) - I believe in incremental small changes. This is behind a feature flag so it's ok 👌 - Nothing bad broke 🤣
prologic merged commit 760df68c78 into main 2 weeks ago
prologic deleted branch filter_and_lists 2 weeks ago

Reviewers

xuu was requested for review 4 weeks ago
sorenpeter was requested for review 4 weeks ago
tkanos was requested for review 4 weeks ago
eaplmx was requested for review 4 weeks ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 760df68c78.
Sign in to join this conversation.
Loading…
There is no content yet.