feature/add-git-timeline-renderer #863
Merged
prologic
merged 2 commits from tkanos/yarn:feature/add-git-timeline-renderer
into main
2 months ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'tkanos/yarn:feature/add-git-timeline-renderer'
Deleting a branch is permanent. It CANNOT be undone. Continue?
I did some Refactor : I remove the if else on the timeline.go, to create :
For the current code I have just :
For Git_parser :
To test :
Seems to work for me 😂 Whilst I don't like the output (it seems noisey to me, but that's just my opinion mostly becuase of my vision impairment!) I'll revoew the code changes here shortly and merge 👌
Yep it's just geeky, but the most important here is the refactoring, to be able to handle many "parser" or "render", you name it.
I can remove the git part if you prefer (not married with it, even if I loved the tests I did)
The refactoring part is important for example, for the next PR, where easily i can add a new "parser" that is the -f option from tail.
@tkanos No, please lave it 😅 I will just focus on the refactoring, don't worry about my opinion per se on the UX of it, I'm sure it can be improved over time 👌
LGTM 👌
f647be900c
into main 2 months agoReviewers
f647be900c
.