Fix registration spam #981

Merged
prologic merged 4 commits from fix_register_spam into main 1 week ago
Owner

Fixes #962

Fixes #962
prologic added 1 commit 3 weeks ago
1219c70980
Fix registration spam
prologic requested review from markwylde 3 weeks ago
prologic requested review from xuu 3 weeks ago
prologic requested review from jlj 3 weeks ago
Owner

I think this could confuse people using screen readers or text browsers. Do you think the robots are sophisticated enough to detect placeholder or at least aria-label text that says "Leave this field blank"?

I imagine many robots are sophisticated enough to leave type="hidden" or aria-hidden="true" fields alone, though.

I think this could confuse people using screen readers or text browsers. Do you think the robots are sophisticated enough to detect `placeholder` or at least `aria-label` text that says "Leave this field blank"? I imagine many robots *are* sophisticated enough to leave `type="hidden"` or `aria-hidden="true"` fields alone, though.
Poster
Owner

I think this could confuse people using screen readers or text browsers. Do you think the robots are sophisticated enough to detect placeholder or at least aria-label text that says "Leave this field blank"?

I like it! 😍 cc @markwylde who I consider a UX expert in this area and als knows about Aria stuff 😅

I imagine many robots are sophisticated enough to leave type="hidden" or aria-hidden="true" fields alone, though.

Yeah without doing any reserach (I tried) I agree 👌

> I think this could confuse people using screen readers or text browsers. Do you think the robots are sophisticated enough to detect `placeholder` or at least `aria-label` text that says "Leave this field blank"? I like it! 😍 cc @markwylde who I consider a UX expert in this area and als knows about Aria stuff 😅 > I imagine many robots *are* sophisticated enough to leave `type="hidden"` or `aria-hidden="true"` fields alone, though. Yeah without doing any reserach (_I tried_) I agree 👌

I would highly appreciate such things. As it would probably defend the users on my instance.

I would highly appreciate such things. As it would probably defend the users on my instance.
lyse approved these changes 3 weeks ago
lyse left a comment
Owner

Just like mckinley said, a label would be helpful. But currently, in w3m the registration form is not really useable anyways. CSS trickery for labels doesn't work with text browsers. So from my point of view this could be merged as is.

Edit: I created #982 for the labels.

Just like mckinley said, a label would be helpful. But currently, in w3m the registration form is not really useable anyways. CSS trickery for labels doesn't work with text browsers. So from my point of view this could be merged as is. Edit: I created https://git.mills.io/yarnsocial/yarn/issues/982 for the labels.
{{ (tr . "RegisterFormGuidelines") | html }}
</label>
</fieldset>
<input class="pooh" name="_pooh" value="" />
Owner

I reckon a label "Leave this field empty" would be very beneficial. Maybe also remove the underscore from the name.

I reckon a label "Leave this field empty" would be very beneficial. Maybe also remove the underscore from the name.
prologic marked this conversation as resolved
prologic added 1 commit 3 weeks ago
b12f45c334
Implement @Lyse's suggestion
lyse requested changes 3 weeks ago
}
.pooh {
opacity: 0;
Owner

Since I'm not a web guy I have no real clue how to handle that properly. But when I want to hide things, I usually just go for display: none and maybe an additional visibility: hidden (although I have no idea why I add that, must have read it a few hundred years ago and never checked it really).

Point is I completely leave opacity, position, etc. alone. What's the recommended way to hide stuff these days?

Since I'm not a web guy I have no real clue how to handle that properly. But when I want to hide things, I usually just go for `display: none` and maybe an additional `visibility: hidden` (although I have no idea why I add that, must have read it a few hundred years ago and never checked it really). Point is I completely leave `opacity`, `position`, etc. alone. What's the recommended way to hide stuff these days?
Poster
Owner

I actually lifted this bit of CSS from an article I read on this, and it was recommended not to use display: none or visibility properties because appararently some bots are clever enough to detect this 😂

I actually lifted this bit of CSS from an article I read on this, and it was recommended not to use `display: none` or `visibility` properties because appararently some bots are clever enough to detect this 😂
Owner

Interesting.

If they're detecing display and visibility I think they also manage to catch this, but alright.

Interesting. If they're detecing `display` and `visibility` I think they also manage to catch this, but alright.
Poster
Owner

Yeah to be honest I didn't buy it either but 🤷‍♂️

Yeah to be honest I didn't buy it either but 🤷‍♂️
lyse marked this conversation as resolved
</fieldset>
<label>
<input class="pooh" name="pooh" value="" />
{{ tr . "RegisterFormPooh" }}</b>
Owner

Now this label will always be shown. I reckon the <label> should get the pooh class instead.

Now this label will always be shown. I reckon the `<label>` should get the `pooh` class instead.
Owner

Maybe I'm missing something, but is that closing </b> tag doing anything for us?

Maybe I'm missing something, but is that closing `</b>` tag doing anything for us?
prologic force-pushed fix_register_spam from b12f45c334 to af4f581b54 1 week ago
prologic added 1 commit 1 week ago
fe199c95b0
Fix template
prologic merged commit 7b7044e48e into main 1 week ago
prologic referenced this issue from a commit 1 week ago

Reviewers

markwylde was requested for review 3 weeks ago
xuu was requested for review 3 weeks ago
jlj was requested for review 3 weeks ago
lyse requested changes 3 weeks ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 7b7044e48e.
Sign in to join this conversation.
Loading…
There is no content yet.